[Slackbuilds-users] Problem building latest libfilezilla

[Arnaud]

Hi everybody,

following today's update, I tried rebuilding libfilezilla and got a
problem :
encryption.cpp:13:27: fatal error: nettle/memops.h: No such file or directory

nettle is available in slackware core. In 14.2 it's version is 3.2, released on
28 january 2016.
But as we can see here :
https://github.com/gnutls/nettle/commits/master/memops.h
The file memops.h was added on 5 september 2016, for the 3.3 release.

So it seems that libfilezilla 0.15 cannot be built on a fully patched 14.2
slackware, but may probably work pretty well on -current.

I may be mistaken, so other inputs would be welcome!

Thanks,

[Willy Sudiarto Raharjo]

Post by Arnaud
following today's update, I tried rebuilding libfilezilla and got a
encryption.cpp:13:27: fatal error: nettle/memops.h: No such file or directory
nettle is available in slackware core. In 14.2 it's version is 3.2, released on
28 january 2016.
https://github.com/gnutls/nettle/commits/master/memops.h
The file memops.h was added on 5 september 2016, for the 3.3 release.
So it seems that libfilezilla 0.15 cannot be built on a fully patched 14.2
slackware, but may probably work pretty well on -current.
I may be mistaken, so other inputs would be welcome!

Hi Arnaud

Thanks for spotting my mistake
I did test the build on my desktop machine which was running current.

I'm still discussing it with upstream as how to solve this issue in
libfilezilla.

Meanwhile, you can stick with the current libfilezilla and filezilla
version.

[Arnaud]

Post by Willy Sudiarto Raharjo

Post by Arnaud
following today's update, I tried rebuilding libfilezilla and got a
encryption.cpp:13:27: fatal error: nettle/memops.h: No such file or directory
nettle is available in slackware core. In 14.2 it's version is 3.2, released
on 28 january 2016.
https://github.com/gnutls/nettle/commits/master/memops.h
The file memops.h was added on 5 september 2016, for the 3.3 release.
So it seems that libfilezilla 0.15 cannot be built on a fully patched 14.2
slackware, but may probably work pretty well on -current.
I may be mistaken, so other inputs would be welcome!

Hi Arnaud
Thanks for spotting my mistake
I did test the build on my desktop machine which was running current.
I'm still discussing it with upstream as how to solve this issue in
libfilezilla.
Meanwhile, you can stick with the current libfilezilla and filezilla
version.

Hi !

Might be we'll have to stick with libfilezilla 0.14.0 and filezilla 3.37.4 up
until Slackware 15.0 is out ?
It won't be dramatically long until then I guess.

[B Watson]

Post by Arnaud

Post by Arnaud
encryption.cpp:13:27: fatal error: nettle/memops.h: No such file or directory
https://github.com/gnutls/nettle/commits/master/memops.h
The file memops.h was added on 5 september 2016, for the 3.3 release.
So it seems that libfilezilla 0.15 cannot be built on a fully patched 14.2

Might be we'll have to stick with libfilezilla 0.14.0 and filezilla 3.37.4 up
until Slackware 15.0 is out ?

OK, if you look at that file, all that's in there is a tiny (under 10
lines of code) function, memeql_sec. It's only ever called from one place
in libfilezilla (encryption.cpp), so here's a patch that just adds the
memeql_sec code to encryption.cpp. Builds fine here. And filezilla 3.38.0
build fine against the patched libfilezilla and appears to work correctly
(I have never used filezilla in my life, so someone else might want to
verify that).

In libfilezilla.SlackBuild, add this line just after the big "find"
stanza and before the configure command:

patch -p1 < $CWD/memeql_sec.diff

[Willy Sudiarto Raharjo]

Post by B Watson

Post by Arnaud
Might be we'll have to stick with libfilezilla 0.14.0 and filezilla 3.37.4 up
until Slackware 15.0 is out ?

OK, if you look at that file, all that's in there is a tiny (under 10
lines of code) function, memeql_sec. It's only ever called from one place
in libfilezilla (encryption.cpp), so here's a patch that just adds the
memeql_sec code to encryption.cpp. Builds fine here. And filezilla 3.38.0
build fine against the patched libfilezilla and appears to work correctly
(I have never used filezilla in my life, so someone else might want to
verify that).
In libfilezilla.SlackBuild, add this line just after the big "find"
patch -p1 < $CWD/memeql_sec.diff

Thanks for the patch, but i guess it would be safe to stick with
previous release and wait for upstream decision (which i still haven't
got up to this point).

Worst case is that we will stick with 3.37.4 for 14.2 and that's still
fine with me.